diff options
| author | 2021-08-23 20:25:00 +0200 | |
|---|---|---|
| committer | 2021-08-23 20:25:00 +0200 | |
| commit | c59f13a82599385891203c1374cdb3d1cf2001f9 (patch) | |
| tree | 7a84dbf7cbd2e689916db42a023159f30b586d89 | |
| parent | Improve cache iteration speed (diff) | |
| parent | Merge pull request #1682 from python-discord/feat/mod/1665/override-auto-mute (diff) | |
Merge branch 'main' into mbaruh/anti-spam
Diffstat (limited to '')
| -rw-r--r-- | bot/constants.py | 2 | ||||
| -rw-r--r-- | bot/converters.py | 85 | ||||
| -rw-r--r-- | bot/errors.py | 7 | ||||
| -rw-r--r-- | bot/exts/fun/duck_pond.py | 5 | ||||
| -rw-r--r-- | bot/exts/info/information.py | 42 | ||||
| -rw-r--r-- | bot/exts/info/python_news.py | 10 | ||||
| -rw-r--r-- | bot/exts/info/site.py | 14 | ||||
| -rw-r--r-- | bot/exts/moderation/infraction/_scheduler.py | 46 | ||||
| -rw-r--r-- | bot/exts/moderation/infraction/_utils.py | 35 | ||||
| -rw-r--r-- | bot/exts/moderation/infraction/infractions.py | 114 | ||||
| -rw-r--r-- | bot/exts/moderation/infraction/management.py | 25 | ||||
| -rw-r--r-- | bot/exts/moderation/infraction/superstarify.py | 25 | ||||
| -rw-r--r-- | bot/exts/moderation/metabase.py | 109 | ||||
| -rw-r--r-- | bot/exts/moderation/watchchannels/bigbrother.py | 12 | ||||
| -rw-r--r-- | bot/exts/recruitment/talentpool/_cog.py | 18 | ||||
| -rw-r--r-- | bot/exts/utils/reminders.py | 50 | ||||
| -rw-r--r-- | config-default.yml | 10 | ||||
| -rw-r--r-- | tests/bot/exts/moderation/infraction/test_infractions.py | 6 | ||||
| -rw-r--r-- | tests/bot/exts/moderation/infraction/test_utils.py | 4 | 
19 files changed, 308 insertions, 311 deletions
| diff --git a/bot/constants.py b/bot/constants.py index 34a814035..407646b28 100644 --- a/bot/constants.py +++ b/bot/constants.py @@ -568,7 +568,7 @@ class Metabase(metaclass=YAMLGetter):      username: Optional[str]      password: Optional[str] -    url: str +    base_url: str      max_session_age: int diff --git a/bot/converters.py b/bot/converters.py index 595809517..37eb91c7f 100644 --- a/bot/converters.py +++ b/bot/converters.py @@ -2,7 +2,6 @@ import logging  import re  import typing as t  from datetime import datetime -from functools import partial  from ssl import CertificateError  import dateutil.parser @@ -439,29 +438,6 @@ class HushDurationConverter(Converter):          return duration -def proxy_user(user_id: str) -> discord.Object: -    """ -    Create a proxy user object from the given id. - -    Used when a Member or User object cannot be resolved. -    """ -    log.trace(f"Attempting to create a proxy user for the user id {user_id}.") - -    try: -        user_id = int(user_id) -    except ValueError: -        log.debug(f"Failed to create proxy user {user_id}: could not convert to int.") -        raise BadArgument(f"User ID `{user_id}` is invalid - could not convert to an integer.") - -    user = discord.Object(user_id) -    user.mention = user.id -    user.display_name = f"<@{user.id}>" -    user.avatar_url_as = lambda static_format: None -    user.bot = False - -    return user - -  class UserMentionOrID(UserConverter):      """      Converts to a `discord.User`, but only if a mention or userID is provided. @@ -480,64 +456,6 @@ class UserMentionOrID(UserConverter):              raise BadArgument(f"`{argument}` is not a User mention or a User ID.") -class FetchedUser(UserConverter): -    """ -    Converts to a `discord.User` or, if it fails, a `discord.Object`. - -    Unlike the default `UserConverter`, which only does lookups via the global user cache, this -    converter attempts to fetch the user via an API call to Discord when the using the cache is -    unsuccessful. - -    If the fetch also fails and the error doesn't imply the user doesn't exist, then a -    `discord.Object` is returned via the `user_proxy` converter. - -    The lookup strategy is as follows (in order): - -    1. Lookup by ID. -    2. Lookup by mention. -    3. Lookup by name#discrim -    4. Lookup by name -    5. Lookup via API -    6. Create a proxy user with discord.Object -    """ - -    async def convert(self, ctx: Context, arg: str) -> t.Union[discord.User, discord.Object]: -        """Convert the `arg` to a `discord.User` or `discord.Object`.""" -        try: -            return await super().convert(ctx, arg) -        except BadArgument: -            pass - -        try: -            user_id = int(arg) -            log.trace(f"Fetching user {user_id}...") -            return await ctx.bot.fetch_user(user_id) -        except ValueError: -            log.debug(f"Failed to fetch user {arg}: could not convert to int.") -            raise BadArgument(f"The provided argument can't be turned into integer: `{arg}`") -        except discord.HTTPException as e: -            # If the Discord error isn't `Unknown user`, return a proxy instead -            if e.code != 10013: -                log.info(f"Failed to fetch user, returning a proxy instead: status {e.status}") -                return proxy_user(arg) - -            log.debug(f"Failed to fetch user {arg}: user does not exist.") -            raise BadArgument(f"User `{arg}` does not exist") - - -def _snowflake_from_regex(pattern: t.Pattern, arg: str) -> int: -    """ -    Extract the snowflake from `arg` using a regex `pattern` and return it as an int. - -    The snowflake is expected to be within the first capture group in `pattern`. -    """ -    match = pattern.match(arg) -    if not match: -        raise BadArgument(f"Mention {str!r} is invalid.") - -    return int(match.group(1)) - -  class Infraction(Converter):      """      Attempts to convert a given infraction ID into an infraction. @@ -568,5 +486,4 @@ class Infraction(Converter):  Expiry = t.Union[Duration, ISODateTime] -FetchedMember = t.Union[discord.Member, FetchedUser] -UserMention = partial(_snowflake_from_regex, RE_USER_MENTION) +MemberOrUser = t.Union[discord.Member, discord.User] diff --git a/bot/errors.py b/bot/errors.py index 5785faa44..08396ec3e 100644 --- a/bot/errors.py +++ b/bot/errors.py @@ -1,6 +1,6 @@ -from typing import Hashable, Union +from typing import Hashable -from discord import Member, User +from bot.converters import MemberOrUser  class LockedResourceError(RuntimeError): @@ -30,7 +30,8 @@ class InvalidInfractedUserError(Exception):          `user` -- User or Member which is invalid      """ -    def __init__(self, user: Union[Member, User], reason: str = "User infracted is a bot."): +    def __init__(self, user: MemberOrUser, reason: str = "User infracted is a bot."): +          self.user = user          self.reason = reason diff --git a/bot/exts/fun/duck_pond.py b/bot/exts/fun/duck_pond.py index d02912545..7f7e4585c 100644 --- a/bot/exts/fun/duck_pond.py +++ b/bot/exts/fun/duck_pond.py @@ -3,11 +3,12 @@ import logging  from typing import Union  import discord -from discord import Color, Embed, Member, Message, RawReactionActionEvent, TextChannel, User, errors +from discord import Color, Embed, Message, RawReactionActionEvent, TextChannel, errors  from discord.ext.commands import Cog, Context, command  from bot import constants  from bot.bot import Bot +from bot.converters import MemberOrUser  from bot.utils.checks import has_any_role  from bot.utils.messages import count_unique_users_reaction, send_attachments  from bot.utils.webhooks import send_webhook @@ -36,7 +37,7 @@ class DuckPond(Cog):              log.exception(f"Failed to fetch webhook with id `{self.webhook_id}`")      @staticmethod -    def is_staff(member: Union[User, Member]) -> bool: +    def is_staff(member: MemberOrUser) -> bool:          """Check if a specific member or user is staff."""          if hasattr(member, "roles"):              for role in member.roles: diff --git a/bot/exts/info/information.py b/bot/exts/info/information.py index 167731e64..8bef6a8cd 100644 --- a/bot/exts/info/information.py +++ b/bot/exts/info/information.py @@ -8,11 +8,12 @@ from typing import Any, DefaultDict, Mapping, Optional, Tuple, Union  import rapidfuzz  from discord import AllowedMentions, Colour, Embed, Guild, Message, Role  from discord.ext.commands import BucketType, Cog, Context, Paginator, command, group, has_any_role +from discord.utils import escape_markdown  from bot import constants  from bot.api import ResponseCodeError  from bot.bot import Bot -from bot.converters import FetchedMember +from bot.converters import MemberOrUser  from bot.decorators import in_whitelist  from bot.errors import NonExistentRoleError  from bot.pagination import LinePaginator @@ -186,21 +187,21 @@ class Information(Cog):          online_presences = py_invite.approximate_presence_count          offline_presences = py_invite.approximate_member_count - online_presences          member_status = ( -            f"{constants.Emojis.status_online} {online_presences} " -            f"{constants.Emojis.status_offline} {offline_presences}" +            f"{constants.Emojis.status_online} {online_presences:,} " +            f"{constants.Emojis.status_offline} {offline_presences:,}"          ) -        embed.description = textwrap.dedent(f""" -            Created: {created} -            Voice region: {region}\ -            {features} -            Roles: {num_roles} -            Member status: {member_status} -        """) +        embed.description = ( +            f"Created: {created}" +            f"\nVoice region: {region}" +            f"{features}" +            f"\nRoles: {num_roles}" +            f"\nMember status: {member_status}" +        )          embed.set_thumbnail(url=ctx.guild.icon_url)          # Members -        total_members = ctx.guild.member_count +        total_members = f"{ctx.guild.member_count:,}"          member_counts = self.get_member_counts(ctx.guild)          member_info = "\n".join(f"{role}: {count}" for role, count in member_counts.items())          embed.add_field(name=f"Members: {total_members}", value=member_info) @@ -220,7 +221,7 @@ class Information(Cog):          await ctx.send(embed=embed)      @command(name="user", aliases=["user_info", "member", "member_info", "u"]) -    async def user_info(self, ctx: Context, user: FetchedMember = None) -> None: +    async def user_info(self, ctx: Context, user: MemberOrUser = None) -> None:          """Returns info about a user."""          if user is None:              user = ctx.author @@ -235,7 +236,7 @@ class Information(Cog):              embed = await self.create_user_embed(ctx, user)              await ctx.send(embed=embed) -    async def create_user_embed(self, ctx: Context, user: FetchedMember) -> Embed: +    async def create_user_embed(self, ctx: Context, user: MemberOrUser) -> Embed:          """Creates an embed containing information on the `user`."""          on_server = bool(ctx.guild.get_member(user.id)) @@ -244,6 +245,7 @@ class Information(Cog):          name = str(user)          if on_server and user.nick:              name = f"{user.nick} ({name})" +        name = escape_markdown(name)          if user.public_flags.verified_bot:              name += f" {constants.Emojis.verified_bot}" @@ -257,7 +259,11 @@ class Information(Cog):                  badges.append(emoji)          if on_server: -            joined = discord_timestamp(user.joined_at, TimestampFormats.RELATIVE) +            if user.joined_at: +                joined = discord_timestamp(user.joined_at, TimestampFormats.RELATIVE) +            else: +                joined = "Unable to get join date" +              # The 0 is for excluding the default @everyone role,              # and the -1 is for reversing the order of the roles to highest to lowest in hierarchy.              roles = ", ".join(role.mention for role in user.roles[:0:-1]) @@ -307,7 +313,7 @@ class Information(Cog):          return embed -    async def basic_user_infraction_counts(self, user: FetchedMember) -> Tuple[str, str]: +    async def basic_user_infraction_counts(self, user: MemberOrUser) -> Tuple[str, str]:          """Gets the total and active infraction counts for the given `member`."""          infractions = await self.bot.api_client.get(              'bot/infractions', @@ -324,7 +330,7 @@ class Information(Cog):          return "Infractions", infraction_output -    async def expanded_user_infraction_counts(self, user: FetchedMember) -> Tuple[str, str]: +    async def expanded_user_infraction_counts(self, user: MemberOrUser) -> Tuple[str, str]:          """          Gets expanded infraction counts for the given `member`. @@ -365,7 +371,7 @@ class Information(Cog):          return "Infractions", "\n".join(infraction_output) -    async def user_nomination_counts(self, user: FetchedMember) -> Tuple[str, str]: +    async def user_nomination_counts(self, user: MemberOrUser) -> Tuple[str, str]:          """Gets the active and historical nomination counts for the given `member`."""          nominations = await self.bot.api_client.get(              'bot/nominations', @@ -390,7 +396,7 @@ class Information(Cog):          return "Nominations", "\n".join(output) -    async def user_messages(self, user: FetchedMember) -> Tuple[Union[bool, str], Tuple[str, str]]: +    async def user_messages(self, user: MemberOrUser) -> Tuple[Union[bool, str], Tuple[str, str]]:          """          Gets the amount of messages for `member`. diff --git a/bot/exts/info/python_news.py b/bot/exts/info/python_news.py index a7837c93a..63eb4ac17 100644 --- a/bot/exts/info/python_news.py +++ b/bot/exts/info/python_news.py @@ -1,4 +1,5 @@  import logging +import re  import typing as t  from datetime import date, datetime @@ -72,6 +73,11 @@ class PythonNews(Cog):              if mail["name"].split("@")[0] in constants.PythonNews.mail_lists:                  self.webhook_names[mail["name"].split("@")[0]] = mail["display_name"] +    @staticmethod +    def escape_markdown(content: str) -> str: +        """Escape the markdown underlines and spoilers.""" +        return re.sub(r"[_|]", lambda match: "\\" + match[0], content) +      async def post_pep_news(self) -> None:          """Fetch new PEPs and when they don't have announcement in #python-news, create it."""          # Wait until everything is ready and http_session available @@ -103,7 +109,7 @@ class PythonNews(Cog):              # Build an embed and send a webhook              embed = discord.Embed(                  title=new["title"], -                description=new["summary"], +                description=self.escape_markdown(new["summary"]),                  timestamp=new_datetime,                  url=new["link"],                  colour=constants.Colours.soft_green @@ -167,7 +173,7 @@ class PythonNews(Cog):                  ):                      continue -                content = email_information["content"] +                content = self.escape_markdown(email_information["content"])                  link = THREAD_URL.format(id=thread["href"].split("/")[-2], list=maillist)                  # Build an embed and send a message to the webhook diff --git a/bot/exts/info/site.py b/bot/exts/info/site.py index fb5b99086..28eb558a6 100644 --- a/bot/exts/info/site.py +++ b/bot/exts/info/site.py @@ -9,7 +9,7 @@ from bot.pagination import LinePaginator  log = logging.getLogger(__name__) -PAGES_URL = f"{URLs.site_schema}{URLs.site}/pages" +BASE_URL = f"{URLs.site_schema}{URLs.site}"  class Site(Cog): @@ -43,7 +43,7 @@ class Site(Cog):      @site_group.command(name="resources", root_aliases=("resources", "resource"))      async def site_resources(self, ctx: Context) -> None:          """Info about the site's Resources page.""" -        learning_url = f"{PAGES_URL}/resources" +        learning_url = f"{BASE_URL}/resources"          embed = Embed(title="Resources")          embed.set_footer(text=f"{learning_url}") @@ -59,7 +59,7 @@ class Site(Cog):      @site_group.command(name="tools", root_aliases=("tools",))      async def site_tools(self, ctx: Context) -> None:          """Info about the site's Tools page.""" -        tools_url = f"{PAGES_URL}/resources/tools" +        tools_url = f"{BASE_URL}/resources/tools"          embed = Embed(title="Tools")          embed.set_footer(text=f"{tools_url}") @@ -74,7 +74,7 @@ class Site(Cog):      @site_group.command(name="help")      async def site_help(self, ctx: Context) -> None:          """Info about the site's Getting Help page.""" -        url = f"{PAGES_URL}/resources/guides/asking-good-questions" +        url = f"{BASE_URL}/pages/guides/pydis-guides/asking-good-questions/"          embed = Embed(title="Asking Good Questions")          embed.set_footer(text=url) @@ -90,7 +90,7 @@ class Site(Cog):      @site_group.command(name="faq", root_aliases=("faq",))      async def site_faq(self, ctx: Context) -> None:          """Info about the site's FAQ page.""" -        url = f"{PAGES_URL}/frequently-asked-questions" +        url = f"{BASE_URL}/pages/frequently-asked-questions"          embed = Embed(title="FAQ")          embed.set_footer(text=url) @@ -107,13 +107,13 @@ class Site(Cog):      @site_group.command(name="rules", aliases=("r", "rule"), root_aliases=("rules", "rule"))      async def site_rules(self, ctx: Context, rules: Greedy[int]) -> None:          """Provides a link to all rules or, if specified, displays specific rule(s).""" -        rules_embed = Embed(title='Rules', color=Colour.blurple(), url=f'{PAGES_URL}/rules') +        rules_embed = Embed(title='Rules', color=Colour.blurple(), url=f'{BASE_URL}/pages/rules')          if not rules:              # Rules were not submitted. Return the default description.              rules_embed.description = (                  "The rules and guidelines that apply to this community can be found on" -                f" our [rules page]({PAGES_URL}/rules). We expect" +                f" our [rules page]({BASE_URL}/pages/rules). We expect"                  " all members of the community to have read and understood these."              ) diff --git a/bot/exts/moderation/infraction/_scheduler.py b/bot/exts/moderation/infraction/_scheduler.py index 8286d3635..6ba4e74e9 100644 --- a/bot/exts/moderation/infraction/_scheduler.py +++ b/bot/exts/moderation/infraction/_scheduler.py @@ -13,8 +13,8 @@ from bot import constants  from bot.api import ResponseCodeError  from bot.bot import Bot  from bot.constants import Colours +from bot.converters import MemberOrUser  from bot.exts.moderation.infraction import _utils -from bot.exts.moderation.infraction._utils import UserSnowflake  from bot.exts.moderation.modlog import ModLog  from bot.utils import messages, scheduling, time  from bot.utils.channel import is_mod_channel @@ -115,7 +115,7 @@ class InfractionScheduler:          self,          ctx: Context,          infraction: _utils.Infraction, -        user: UserSnowflake, +        user: MemberOrUser,          action_coro: t.Optional[t.Awaitable] = None,          user_reason: t.Optional[str] = None,          additional_info: str = "", @@ -165,17 +165,10 @@ class InfractionScheduler:              dm_result = f"{constants.Emojis.failmail} "              dm_log_text = "\nDM: **Failed**" -            # Sometimes user is a discord.Object; make it a proper user. -            try: -                if not isinstance(user, (discord.Member, discord.User)): -                    user = await self.bot.fetch_user(user.id) -            except discord.HTTPException as e: -                log.error(f"Failed to DM {user.id}: could not fetch user (status {e.status})") -            else: -                # Accordingly display whether the user was successfully notified via DM. -                if await _utils.notify_infraction(user, infr_type.replace("_", " ").title(), expiry, user_reason, icon): -                    dm_result = ":incoming_envelope: " -                    dm_log_text = "\nDM: Sent" +            # Accordingly display whether the user was successfully notified via DM. +            if await _utils.notify_infraction(user, infr_type.replace("_", " ").title(), expiry, user_reason, icon): +                dm_result = ":incoming_envelope: " +                dm_log_text = "\nDM: Sent"          end_msg = ""          if infraction["actor"] == self.bot.user.id: @@ -264,14 +257,18 @@ class InfractionScheduler:              self,              ctx: Context,              infr_type: str, -            user: UserSnowflake, -            send_msg: bool = True +            user: MemberOrUser, +            *, +            send_msg: bool = True, +            notify: bool = True      ) -> None:          """          Prematurely end an infraction for a user and log the action in the mod log.          If `send_msg` is True, then a pardoning confirmation message will be sent to -        the context channel.  Otherwise, no such message will be sent. +        the context channel. Otherwise, no such message will be sent. + +        If `notify` is True, notify the user of the pardon via DM where applicable.          """          log.trace(f"Pardoning {infr_type} infraction for {user}.") @@ -292,7 +289,7 @@ class InfractionScheduler:              return          # Deactivate the infraction and cancel its scheduled expiration task. -        log_text = await self.deactivate_infraction(response[0], send_log=False) +        log_text = await self.deactivate_infraction(response[0], send_log=False, notify=notify)          log_text["Member"] = messages.format_user(user)          log_text["Actor"] = ctx.author.mention @@ -345,7 +342,9 @@ class InfractionScheduler:      async def deactivate_infraction(          self,          infraction: _utils.Infraction, -        send_log: bool = True +        *, +        send_log: bool = True, +        notify: bool = True      ) -> t.Dict[str, str]:          """          Deactivate an active infraction and return a dictionary of lines to send in a mod log. @@ -354,6 +353,8 @@ class InfractionScheduler:          expiration task cancelled. If `send_log` is True, a mod log is sent for the          deactivation of the infraction. +        If `notify` is True, notify the user of the pardon via DM where applicable. +          Infractions of unsupported types will raise a ValueError.          """          guild = self.bot.get_guild(constants.Guild.id) @@ -380,7 +381,7 @@ class InfractionScheduler:          try:              log.trace("Awaiting the pardon action coroutine.") -            returned_log = await self._pardon_action(infraction) +            returned_log = await self._pardon_action(infraction, notify)              if returned_log is not None:                  log_text = {**log_text, **returned_log}  # Merge the logs together @@ -468,10 +469,15 @@ class InfractionScheduler:          return log_text      @abstractmethod -    async def _pardon_action(self, infraction: _utils.Infraction) -> t.Optional[t.Dict[str, str]]: +    async def _pardon_action( +        self, +        infraction: _utils.Infraction, +        notify: bool +    ) -> t.Optional[t.Dict[str, str]]:          """          Execute deactivation steps specific to the infraction's type and return a log dict. +        If `notify` is True, notify the user of the pardon via DM where applicable.          If an infraction type is unsupported, return None instead.          """          raise NotImplementedError diff --git a/bot/exts/moderation/infraction/_utils.py b/bot/exts/moderation/infraction/_utils.py index a4059a6e9..b20ef1d06 100644 --- a/bot/exts/moderation/infraction/_utils.py +++ b/bot/exts/moderation/infraction/_utils.py @@ -7,6 +7,7 @@ from discord.ext.commands import Context  from bot.api import ResponseCodeError  from bot.constants import Colours, Icons +from bot.converters import MemberOrUser  from bot.errors import InvalidInfractedUserError  log = logging.getLogger(__name__) @@ -24,8 +25,6 @@ INFRACTION_ICONS = {  RULES_URL = "https://pythondiscord.com/pages/rules"  # Type aliases -UserObject = t.Union[discord.Member, discord.User] -UserSnowflake = t.Union[UserObject, discord.Object]  Infraction = t.Dict[str, t.Union[str, int, bool]]  APPEAL_EMAIL = "[email protected]" @@ -45,7 +44,7 @@ INFRACTION_DESCRIPTION_TEMPLATE = (  ) -async def post_user(ctx: Context, user: UserSnowflake) -> t.Optional[dict]: +async def post_user(ctx: Context, user: MemberOrUser) -> t.Optional[dict]:      """      Create a new user in the database. @@ -53,14 +52,11 @@ async def post_user(ctx: Context, user: UserSnowflake) -> t.Optional[dict]:      """      log.trace(f"Attempting to add user {user.id} to the database.") -    if not isinstance(user, (discord.Member, discord.User)): -        log.debug("The user being added to the DB is not a Member or User object.") -      payload = { -        'discriminator': int(getattr(user, 'discriminator', 0)), +        'discriminator': int(user.discriminator),          'id': user.id,          'in_guild': False, -        'name': getattr(user, 'name', 'Name unknown'), +        'name': user.name,          'roles': []      } @@ -75,7 +71,7 @@ async def post_user(ctx: Context, user: UserSnowflake) -> t.Optional[dict]:  async def post_infraction(          ctx: Context, -        user: UserSnowflake, +        user: MemberOrUser,          infr_type: str,          reason: str,          expires_at: datetime = None, @@ -118,7 +114,7 @@ async def post_infraction(  async def get_active_infraction(          ctx: Context, -        user: UserSnowflake, +        user: MemberOrUser,          infr_type: str,          send_msg: bool = True  ) -> t.Optional[dict]: @@ -143,17 +139,22 @@ async def get_active_infraction(          # Checks to see if the moderator should be told there is an active infraction          if send_msg:              log.trace(f"{user} has active infractions of type {infr_type}.") -            await ctx.send( -                f":x: According to my records, this user already has a {infr_type} infraction. " -                f"See infraction **#{active_infractions[0]['id']}**." -            ) +            await send_active_infraction_message(ctx, active_infractions[0])          return active_infractions[0]      else:          log.trace(f"{user} does not have active infractions of type {infr_type}.") +async def send_active_infraction_message(ctx: Context, infraction: Infraction) -> None: +    """Send a message stating that the given infraction is active.""" +    await ctx.send( +        f":x: According to my records, this user already has a {infraction['type']} infraction. " +        f"See infraction **#{infraction['id']}**." +    ) + +  async def notify_infraction( -        user: UserObject, +        user: MemberOrUser,          infr_type: str,          expires_at: t.Optional[str] = None,          reason: t.Optional[str] = None, @@ -189,7 +190,7 @@ async def notify_infraction(  async def notify_pardon( -        user: UserObject, +        user: MemberOrUser,          title: str,          content: str,          icon_url: str = Icons.user_verified @@ -207,7 +208,7 @@ async def notify_pardon(      return await send_private_embed(user, embed) -async def send_private_embed(user: UserObject, embed: discord.Embed) -> bool: +async def send_private_embed(user: MemberOrUser, embed: discord.Embed) -> bool:      """      A helper method for sending an embed to a user's DMs. diff --git a/bot/exts/moderation/infraction/infractions.py b/bot/exts/moderation/infraction/infractions.py index f19323c7c..2f9083c29 100644 --- a/bot/exts/moderation/infraction/infractions.py +++ b/bot/exts/moderation/infraction/infractions.py @@ -10,11 +10,10 @@ from discord.ext.commands import Context, command  from bot import constants  from bot.bot import Bot  from bot.constants import Event -from bot.converters import Duration, Expiry, FetchedMember +from bot.converters import Duration, Expiry, MemberOrUser  from bot.decorators import respect_role_hierarchy  from bot.exts.moderation.infraction import _utils  from bot.exts.moderation.infraction._scheduler import InfractionScheduler -from bot.exts.moderation.infraction._utils import UserSnowflake  from bot.utils.messages import format_user  log = logging.getLogger(__name__) @@ -54,7 +53,7 @@ class Infractions(InfractionScheduler, commands.Cog):      # region: Permanent infractions      @command() -    async def warn(self, ctx: Context, user: FetchedMember, *, reason: t.Optional[str] = None) -> None: +    async def warn(self, ctx: Context, user: MemberOrUser, *, reason: t.Optional[str] = None) -> None:          """Warn a user for the given reason."""          if not isinstance(user, Member):              await ctx.send(":x: The user doesn't appear to be on the server.") @@ -67,7 +66,7 @@ class Infractions(InfractionScheduler, commands.Cog):          await self.apply_infraction(ctx, infraction, user)      @command() -    async def kick(self, ctx: Context, user: FetchedMember, *, reason: t.Optional[str] = None) -> None: +    async def kick(self, ctx: Context, user: MemberOrUser, *, reason: t.Optional[str] = None) -> None:          """Kick a user for the given reason."""          if not isinstance(user, Member):              await ctx.send(":x: The user doesn't appear to be on the server.") @@ -79,7 +78,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def ban(          self,          ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: t.Optional[Expiry] = None,          *,          reason: t.Optional[str] = None @@ -95,7 +94,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def purgeban(          self,          ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: t.Optional[Expiry] = None,          *,          reason: t.Optional[str] = None @@ -111,7 +110,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def voiceban(          self,          ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: t.Optional[Expiry] = None,          *,          reason: t.Optional[str] @@ -129,7 +128,7 @@ class Infractions(InfractionScheduler, commands.Cog):      @command(aliases=["mute"])      async def tempmute(          self, ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: t.Optional[Expiry] = None,          *,          reason: t.Optional[str] = None @@ -163,7 +162,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def tempban(          self,          ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: Expiry,          *,          reason: t.Optional[str] = None @@ -189,7 +188,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def tempvoiceban(              self,              ctx: Context, -            user: FetchedMember, +            user: MemberOrUser,              duration: Expiry,              *,              reason: t.Optional[str] @@ -215,7 +214,7 @@ class Infractions(InfractionScheduler, commands.Cog):      # region: Permanent shadow infractions      @command(hidden=True) -    async def note(self, ctx: Context, user: FetchedMember, *, reason: t.Optional[str] = None) -> None: +    async def note(self, ctx: Context, user: MemberOrUser, *, reason: t.Optional[str] = None) -> None:          """Create a private note for a user with the given reason without notifying the user."""          infraction = await _utils.post_infraction(ctx, user, "note", reason, hidden=True, active=False)          if infraction is None: @@ -224,7 +223,7 @@ class Infractions(InfractionScheduler, commands.Cog):          await self.apply_infraction(ctx, infraction, user)      @command(hidden=True, aliases=['shadowban', 'sban']) -    async def shadow_ban(self, ctx: Context, user: FetchedMember, *, reason: t.Optional[str] = None) -> None: +    async def shadow_ban(self, ctx: Context, user: MemberOrUser, *, reason: t.Optional[str] = None) -> None:          """Permanently ban a user for the given reason without notifying the user."""          await self.apply_ban(ctx, user, reason, hidden=True) @@ -235,7 +234,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def shadow_tempban(          self,          ctx: Context, -        user: FetchedMember, +        user: MemberOrUser,          duration: Expiry,          *,          reason: t.Optional[str] = None @@ -261,17 +260,17 @@ class Infractions(InfractionScheduler, commands.Cog):      # region: Remove infractions (un- commands)      @command() -    async def unmute(self, ctx: Context, user: FetchedMember) -> None: +    async def unmute(self, ctx: Context, user: MemberOrUser) -> None:          """Prematurely end the active mute infraction for the user."""          await self.pardon_infraction(ctx, "mute", user)      @command() -    async def unban(self, ctx: Context, user: FetchedMember) -> None: +    async def unban(self, ctx: Context, user: MemberOrUser) -> None:          """Prematurely end the active ban infraction for the user."""          await self.pardon_infraction(ctx, "ban", user)      @command(aliases=("uvban",)) -    async def unvoiceban(self, ctx: Context, user: FetchedMember) -> None: +    async def unvoiceban(self, ctx: Context, user: MemberOrUser) -> None:          """Prematurely end the active voice ban infraction for the user."""          await self.pardon_infraction(ctx, "voice_ban", user) @@ -280,8 +279,19 @@ class Infractions(InfractionScheduler, commands.Cog):      async def apply_mute(self, ctx: Context, user: Member, reason: t.Optional[str], **kwargs) -> None:          """Apply a mute infraction with kwargs passed to `post_infraction`.""" -        if await _utils.get_active_infraction(ctx, user, "mute"): -            return +        if active := await _utils.get_active_infraction(ctx, user, "mute", send_msg=False): +            if active["actor"] != self.bot.user.id: +                await _utils.send_active_infraction_message(ctx, active) +                return + +            # Allow the current mute attempt to override an automatically triggered mute. +            log_text = await self.deactivate_infraction(active, notify=False) +            if "Failure" in log_text: +                await ctx.send( +                    f":x: can't override infraction **mute** for {user.mention}: " +                    f"failed to deactivate. {log_text['Failure']}" +                ) +                return          infraction = await _utils.post_infraction(ctx, user, "mute", reason, active=True, **kwargs)          if infraction is None: @@ -320,7 +330,7 @@ class Infractions(InfractionScheduler, commands.Cog):      async def apply_ban(          self,          ctx: Context, -        user: UserSnowflake, +        user: MemberOrUser,          reason: t.Optional[str],          purge_days: t.Optional[int] = 0,          **kwargs @@ -345,7 +355,7 @@ class Infractions(InfractionScheduler, commands.Cog):                  return              log.trace("Old tempban is being replaced by new permaban.") -            await self.pardon_infraction(ctx, "ban", user, is_temporary) +            await self.pardon_infraction(ctx, "ban", user, send_msg=is_temporary)          infraction = await _utils.post_infraction(ctx, user, "ban", reason, active=True, **kwargs)          if infraction is None: @@ -376,7 +386,7 @@ class Infractions(InfractionScheduler, commands.Cog):          await bb_cog.apply_unwatch(ctx, user, bb_reason, send_message=False)      @respect_role_hierarchy(member_arg=2) -    async def apply_voice_ban(self, ctx: Context, user: UserSnowflake, reason: t.Optional[str], **kwargs) -> None: +    async def apply_voice_ban(self, ctx: Context, user: MemberOrUser, reason: t.Optional[str], **kwargs) -> None:          """Apply a voice ban infraction with kwargs passed to `post_infraction`."""          if await _utils.get_active_infraction(ctx, user, "voice_ban"):              return @@ -403,8 +413,15 @@ class Infractions(InfractionScheduler, commands.Cog):      # endregion      # region: Base pardon functions -    async def pardon_mute(self, user_id: int, guild: discord.Guild, reason: t.Optional[str]) -> t.Dict[str, str]: -        """Remove a user's muted role, DM them a notification, and return a log dict.""" +    async def pardon_mute( +        self, +        user_id: int, +        guild: discord.Guild, +        reason: t.Optional[str], +        *, +        notify: bool = True +    ) -> t.Dict[str, str]: +        """Remove a user's muted role, optionally DM them a notification, and return a log dict."""          user = guild.get_member(user_id)          log_text = {} @@ -413,16 +430,17 @@ class Infractions(InfractionScheduler, commands.Cog):              self.mod_log.ignore(Event.member_update, user.id)              await user.remove_roles(self._muted_role, reason=reason) -            # DM the user about the expiration. -            notified = await _utils.notify_pardon( -                user=user, -                title="You have been unmuted", -                content="You may now send messages in the server.", -                icon_url=_utils.INFRACTION_ICONS["mute"][1] -            ) +            if notify: +                # DM the user about the expiration. +                notified = await _utils.notify_pardon( +                    user=user, +                    title="You have been unmuted", +                    content="You may now send messages in the server.", +                    icon_url=_utils.INFRACTION_ICONS["mute"][1] +                ) +                log_text["DM"] = "Sent" if notified else "**Failed**"              log_text["Member"] = format_user(user) -            log_text["DM"] = "Sent" if notified else "**Failed**"          else:              log.info(f"Failed to unmute user {user_id}: user not found")              log_text["Failure"] = "User was not found in the guild." @@ -444,31 +462,39 @@ class Infractions(InfractionScheduler, commands.Cog):          return log_text -    async def pardon_voice_ban(self, user_id: int, guild: discord.Guild, reason: t.Optional[str]) -> t.Dict[str, str]: -        """Add Voice Verified role back to user, DM them a notification, and return a log dict.""" +    async def pardon_voice_ban( +        self, +        user_id: int, +        guild: discord.Guild, +        *, +        notify: bool = True +    ) -> t.Dict[str, str]: +        """Optionally DM the user a pardon notification and return a log dict."""          user = guild.get_member(user_id)          log_text = {}          if user: -            # DM user about infraction expiration -            notified = await _utils.notify_pardon( -                user=user, -                title="Voice ban ended", -                content="You have been unbanned and can verify yourself again in the server.", -                icon_url=_utils.INFRACTION_ICONS["voice_ban"][1] -            ) +            if notify: +                # DM user about infraction expiration +                notified = await _utils.notify_pardon( +                    user=user, +                    title="Voice ban ended", +                    content="You have been unbanned and can verify yourself again in the server.", +                    icon_url=_utils.INFRACTION_ICONS["voice_ban"][1] +                ) +                log_text["DM"] = "Sent" if notified else "**Failed**"              log_text["Member"] = format_user(user) -            log_text["DM"] = "Sent" if notified else "**Failed**"          else:              log_text["Info"] = "User was not found in the guild."          return log_text -    async def _pardon_action(self, infraction: _utils.Infraction) -> t.Optional[t.Dict[str, str]]: +    async def _pardon_action(self, infraction: _utils.Infraction, notify: bool) -> t.Optional[t.Dict[str, str]]:          """          Execute deactivation steps specific to the infraction's type and return a log dict. +        If `notify` is True, notify the user of the pardon via DM where applicable.          If an infraction type is unsupported, return None instead.          """          guild = self.bot.get_guild(constants.Guild.id) @@ -476,11 +502,11 @@ class Infractions(InfractionScheduler, commands.Cog):          reason = f"Infraction #{infraction['id']} expired or was pardoned."          if infraction["type"] == "mute": -            return await self.pardon_mute(user_id, guild, reason) +            return await self.pardon_mute(user_id, guild, reason, notify=notify)          elif infraction["type"] == "ban":              return await self.pardon_ban(user_id, guild, reason)          elif infraction["type"] == "voice_ban": -            return await self.pardon_voice_ban(user_id, guild, reason) +            return await self.pardon_voice_ban(user_id, guild, notify=notify)      # endregion diff --git a/bot/exts/moderation/infraction/management.py b/bot/exts/moderation/infraction/management.py index 3094159cd..641ad0410 100644 --- a/bot/exts/moderation/infraction/management.py +++ b/bot/exts/moderation/infraction/management.py @@ -12,7 +12,7 @@ from discord.utils import escape_markdown  from bot import constants  from bot.bot import Bot -from bot.converters import Expiry, Infraction, Snowflake, UserMention, allowed_strings, proxy_user +from bot.converters import Expiry, Infraction, MemberOrUser, Snowflake, UserMentionOrID, allowed_strings  from bot.exts.moderation.infraction.infractions import Infractions  from bot.exts.moderation.modlog import ModLog  from bot.pagination import LinePaginator @@ -201,29 +201,34 @@ class ModManagement(commands.Cog):      # region: Search infractions      @infraction_group.group(name="search", aliases=('s',), invoke_without_command=True) -    async def infraction_search_group(self, ctx: Context, query: t.Union[UserMention, Snowflake, str]) -> None: +    async def infraction_search_group(self, ctx: Context, query: t.Union[UserMentionOrID, Snowflake, str]) -> None:          """Searches for infractions in the database."""          if isinstance(query, int):              await self.search_user(ctx, discord.Object(query)) -        else: +        elif isinstance(query, str):              await self.search_reason(ctx, query) +        else: +            await self.search_user(ctx, query)      @infraction_search_group.command(name="user", aliases=("member", "id")) -    async def search_user(self, ctx: Context, user: t.Union[discord.User, proxy_user]) -> None: +    async def search_user(self, ctx: Context, user: t.Union[MemberOrUser, discord.Object]) -> None:          """Search for infractions by member."""          infraction_list = await self.bot.api_client.get(              'bot/infractions/expanded',              params={'user__id': str(user.id)}          ) -        user = self.bot.get_user(user.id) -        if not user and infraction_list: -            # Use the user data retrieved from the DB for the username. -            user = infraction_list[0]["user"] -            user = escape_markdown(user["name"]) + f"#{user['discriminator']:04}" +        if isinstance(user, (discord.Member, discord.User)): +            user_str = escape_markdown(str(user)) +        else: +            if infraction_list: +                user = infraction_list[0]["user"] +                user_str = escape_markdown(user["name"]) + f"#{user['discriminator']:04}" +            else: +                user_str = str(user.id)          embed = discord.Embed( -            title=f"Infractions for {user} ({len(infraction_list)} total)", +            title=f"Infractions for {user_str} ({len(infraction_list)} total)",              colour=discord.Colour.orange()          )          await self.send_infraction_list(ctx, embed, infraction_list) diff --git a/bot/exts/moderation/infraction/superstarify.py b/bot/exts/moderation/infraction/superstarify.py index 07e79b9fe..05a2bbe10 100644 --- a/bot/exts/moderation/infraction/superstarify.py +++ b/bot/exts/moderation/infraction/superstarify.py @@ -192,8 +192,8 @@ class Superstarify(InfractionScheduler, Cog):          """Remove the superstarify infraction and allow the user to change their nickname."""          await self.pardon_infraction(ctx, "superstar", member) -    async def _pardon_action(self, infraction: _utils.Infraction) -> t.Optional[t.Dict[str, str]]: -        """Pardon a superstar infraction and return a log dict.""" +    async def _pardon_action(self, infraction: _utils.Infraction, notify: bool) -> t.Optional[t.Dict[str, str]]: +        """Pardon a superstar infraction, optionally notify the user via DM, and return a log dict."""          if infraction["type"] != "superstar":              return @@ -208,18 +208,19 @@ class Superstarify(InfractionScheduler, Cog):              )              return {} +        log_text = {"Member": format_user(user)} +          # DM the user about the expiration. -        notified = await _utils.notify_pardon( -            user=user, -            title="You are no longer superstarified", -            content="You may now change your nickname on the server.", -            icon_url=_utils.INFRACTION_ICONS["superstar"][1] -        ) +        if notify: +            notified = await _utils.notify_pardon( +                user=user, +                title="You are no longer superstarified", +                content="You may now change your nickname on the server.", +                icon_url=_utils.INFRACTION_ICONS["superstar"][1] +            ) +            log_text["DM"] = "Sent" if notified else "**Failed**" -        return { -            "Member": format_user(user), -            "DM": "Sent" if notified else "**Failed**" -        } +        return log_text      @staticmethod      def get_nick(infraction_id: int, member_id: int) -> str: diff --git a/bot/exts/moderation/metabase.py b/bot/exts/moderation/metabase.py index e9faf7240..3b454ab18 100644 --- a/bot/exts/moderation/metabase.py +++ b/bot/exts/moderation/metabase.py @@ -42,6 +42,25 @@ class Metabase(Cog):          self.init_task = self.bot.loop.create_task(self.init_cog()) +    async def cog_command_error(self, ctx: Context, error: Exception) -> None: +        """Handle ClientResponseError errors locally to invalidate token if needed.""" +        if not isinstance(error.original, ClientResponseError): +            return + +        if error.original.status == 403: +            # User doesn't have access to the given question +            log.warning(f"Failed to auth with Metabase for {error.original.url}.") +            await ctx.send(f":x: {ctx.author.mention} Failed to auth with Metabase for that question.") +        elif error.original.status == 404: +            await ctx.send(f":x: {ctx.author.mention} That question could not be found.") +        else: +            # User credentials are invalid, or the refresh failed. +            # Delete the expiry time, to force a refresh on next startup. +            await self.session_info.delete("session_expiry") +            log.exception("Session token is invalid or refresh failed.") +            await ctx.send(f":x: {ctx.author.mention} Session token is invalid or refresh failed.") +        error.handled = True +      async def init_cog(self) -> None:          """Initialise the metabase session."""          expiry_time = await self.session_info.get("session_expiry") @@ -65,7 +84,7 @@ class Metabase(Cog):              "username": MetabaseConfig.username,              "password": MetabaseConfig.password          } -        async with self.bot.http_session.post(f"{MetabaseConfig.url}/session", json=data) as resp: +        async with self.bot.http_session.post(f"{MetabaseConfig.base_url}/api/session", json=data) as resp:              json_data = await resp.json()              self.session_token = json_data.get("id") @@ -86,7 +105,7 @@ class Metabase(Cog):          """A group of commands for interacting with metabase."""          await ctx.send_help(ctx.command) -    @metabase_group.command(name="extract") +    @metabase_group.command(name="extract", aliases=("export",))      async def metabase_extract(          self,          ctx: Context, @@ -106,48 +125,50 @@ class Metabase(Cog):          Valid extensions are: csv and json.          """ -        async with ctx.typing(): - -            # Make sure we have a session token before running anything -            await self.init_task - -            url = f"{MetabaseConfig.url}/card/{question_id}/query/{extension}" -            try: -                async with self.bot.http_session.post(url, headers=self.headers, raise_for_status=True) as resp: -                    if extension == "csv": -                        out = await resp.text(encoding="utf-8") -                        # Save the output for use with int e -                        self.exports[question_id] = list(csv.DictReader(StringIO(out))) - -                    elif extension == "json": -                        out = await resp.json(encoding="utf-8") -                        # Save the output for use with int e -                        self.exports[question_id] = out - -                        # Format it nicely for human eyes -                        out = json.dumps(out, indent=4, sort_keys=True) -            except ClientResponseError as e: -                if e.status == 403: -                    # User doesn't have access to the given question -                    log.warning(f"Failed to auth with Metabase for question {question_id}.") -                    await ctx.send(f":x: {ctx.author.mention} Failed to auth with Metabase for that question.") -                else: -                    # User credentials are invalid, or the refresh failed. -                    # Delete the expiry time, to force a refresh on next startup. -                    await self.session_info.delete("session_expiry") -                    log.exception("Session token is invalid or refresh failed.") -                    await ctx.send(f":x: {ctx.author.mention} Session token is invalid or refresh failed.") -                return - -            paste_link = await send_to_paste_service(out, extension=extension) -            if paste_link: -                message = f":+1: {ctx.author.mention} Here's your link: {paste_link}" -            else: -                message = f":x: {ctx.author.mention} Link service is unavailible." -            await ctx.send( -                f"{message}\nYou can also access this data within internal eval by doing: " -                f"`bot.get_cog('Metabase').exports[{question_id}]`" -            ) +        await ctx.trigger_typing() + +        # Make sure we have a session token before running anything +        await self.init_task + +        url = f"{MetabaseConfig.base_url}/api/card/{question_id}/query/{extension}" + +        async with self.bot.http_session.post(url, headers=self.headers, raise_for_status=True) as resp: +            if extension == "csv": +                out = await resp.text(encoding="utf-8") +                # Save the output for use with int e +                self.exports[question_id] = list(csv.DictReader(StringIO(out))) + +            elif extension == "json": +                out = await resp.json(encoding="utf-8") +                # Save the output for use with int e +                self.exports[question_id] = out + +                # Format it nicely for human eyes +                out = json.dumps(out, indent=4, sort_keys=True) + +        paste_link = await send_to_paste_service(out, extension=extension) +        if paste_link: +            message = f":+1: {ctx.author.mention} Here's your link: {paste_link}" +        else: +            message = f":x: {ctx.author.mention} Link service is unavailible." +        await ctx.send( +            f"{message}\nYou can also access this data within internal eval by doing: " +            f"`bot.get_cog('Metabase').exports[{question_id}]`" +        ) + +    @metabase_group.command(name="publish", aliases=("share",)) +    async def metabase_publish(self, ctx: Context, question_id: int) -> None: +        """Publically shares the given question and posts the link.""" +        await ctx.trigger_typing() +        # Make sure we have a session token before running anything +        await self.init_task + +        url = f"{MetabaseConfig.base_url}/api/card/{question_id}/public_link" + +        async with self.bot.http_session.post(url, headers=self.headers, raise_for_status=True) as resp: +            response_json = await resp.json(encoding="utf-8") +            sharing_url = f"{MetabaseConfig.base_url}/public/question/{response_json['uuid']}" +            await ctx.send(f":+1: {ctx.author.mention} Here's your sharing link: {sharing_url}")      # This cannot be static (must have a __func__ attribute).      async def cog_check(self, ctx: Context) -> bool: diff --git a/bot/exts/moderation/watchchannels/bigbrother.py b/bot/exts/moderation/watchchannels/bigbrother.py index c6ee844ef..3aa253fea 100644 --- a/bot/exts/moderation/watchchannels/bigbrother.py +++ b/bot/exts/moderation/watchchannels/bigbrother.py @@ -6,7 +6,7 @@ from discord.ext.commands import Cog, Context, group, has_any_role  from bot.bot import Bot  from bot.constants import Channels, MODERATION_ROLES, Webhooks -from bot.converters import FetchedMember +from bot.converters import MemberOrUser  from bot.exts.moderation.infraction._utils import post_infraction  from bot.exts.moderation.watchchannels._watchchannel import WatchChannel @@ -60,7 +60,7 @@ class BigBrother(WatchChannel, Cog, name="Big Brother"):      @bigbrother_group.command(name='watch', aliases=('w',), root_aliases=('watch',))      @has_any_role(*MODERATION_ROLES) -    async def watch_command(self, ctx: Context, user: FetchedMember, *, reason: str) -> None: +    async def watch_command(self, ctx: Context, user: MemberOrUser, *, reason: str) -> None:          """          Relay messages sent by the given `user` to the `#big-brother` channel. @@ -71,11 +71,11 @@ class BigBrother(WatchChannel, Cog, name="Big Brother"):      @bigbrother_group.command(name='unwatch', aliases=('uw',), root_aliases=('unwatch',))      @has_any_role(*MODERATION_ROLES) -    async def unwatch_command(self, ctx: Context, user: FetchedMember, *, reason: str) -> None: +    async def unwatch_command(self, ctx: Context, user: MemberOrUser, *, reason: str) -> None:          """Stop relaying messages by the given `user`."""          await self.apply_unwatch(ctx, user, reason) -    async def apply_watch(self, ctx: Context, user: FetchedMember, reason: str) -> None: +    async def apply_watch(self, ctx: Context, user: MemberOrUser, reason: str) -> None:          """          Add `user` to watched users and apply a watch infraction with `reason`. @@ -94,7 +94,7 @@ class BigBrother(WatchChannel, Cog, name="Big Brother"):              await ctx.send(f":x: {user} is already being watched.")              return -        # FetchedUser instances don't have a roles attribute +        # discord.User instances don't have a roles attribute          if hasattr(user, "roles") and any(role.id in MODERATION_ROLES for role in user.roles):              await ctx.send(f":x: I'm sorry {ctx.author}, I'm afraid I can't do that. I must be kind to my masters.")              return @@ -125,7 +125,7 @@ class BigBrother(WatchChannel, Cog, name="Big Brother"):          await ctx.send(msg) -    async def apply_unwatch(self, ctx: Context, user: FetchedMember, reason: str, send_message: bool = True) -> None: +    async def apply_unwatch(self, ctx: Context, user: MemberOrUser, reason: str, send_message: bool = True) -> None:          """          Remove `user` from watched users and mark their infraction as inactive with `reason`. diff --git a/bot/exts/recruitment/talentpool/_cog.py b/bot/exts/recruitment/talentpool/_cog.py index 80bd48534..5c1a1cd3f 100644 --- a/bot/exts/recruitment/talentpool/_cog.py +++ b/bot/exts/recruitment/talentpool/_cog.py @@ -6,13 +6,13 @@ from typing import Union  import discord  from async_rediscache import RedisCache -from discord import Color, Embed, Member, PartialMessage, RawReactionActionEvent, User +from discord import Color, Embed, Member, PartialMessage, RawReactionActionEvent  from discord.ext.commands import Cog, Context, group, has_any_role  from bot.api import ResponseCodeError  from bot.bot import Bot  from bot.constants import Channels, Emojis, Guild, MODERATION_ROLES, Roles, STAFF_ROLES, Webhooks -from bot.converters import FetchedMember +from bot.converters import MemberOrUser  from bot.exts.moderation.watchchannels._watchchannel import WatchChannel  from bot.exts.recruitment.talentpool._review import Reviewer  from bot.pagination import LinePaginator @@ -178,7 +178,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):      @nomination_group.command(name='forcewatch', aliases=('fw', 'forceadd', 'fa'), root_aliases=("forcenominate",))      @has_any_role(*MODERATION_ROLES) -    async def force_watch_command(self, ctx: Context, user: FetchedMember, *, reason: str = '') -> None: +    async def force_watch_command(self, ctx: Context, user: MemberOrUser, *, reason: str = '') -> None:          """          Adds the given `user` to the talent pool, from any channel. @@ -188,7 +188,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):      @nomination_group.command(name='watch', aliases=('w', 'add', 'a'), root_aliases=("nominate",))      @has_any_role(*STAFF_ROLES) -    async def watch_command(self, ctx: Context, user: FetchedMember, *, reason: str = '') -> None: +    async def watch_command(self, ctx: Context, user: MemberOrUser, *, reason: str = '') -> None:          """          Adds the given `user` to the talent pool. @@ -207,7 +207,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):          await self._watch_user(ctx, user, reason) -    async def _watch_user(self, ctx: Context, user: FetchedMember, reason: str) -> None: +    async def _watch_user(self, ctx: Context, user: MemberOrUser, reason: str) -> None:          """Adds the given user to the talent pool."""          if user.bot:              await ctx.send(f":x: I'm sorry {ctx.author}, I'm afraid I can't do that. I only watch humans.") @@ -271,7 +271,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):      @nomination_group.command(name='history', aliases=('info', 'search'))      @has_any_role(*MODERATION_ROLES) -    async def history_command(self, ctx: Context, user: FetchedMember) -> None: +    async def history_command(self, ctx: Context, user: MemberOrUser) -> None:          """Shows the specified user's nomination history."""          result = await self.bot.api_client.get(              self.api_endpoint, @@ -300,7 +300,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):      @nomination_group.command(name='unwatch', aliases=('end', ), root_aliases=("unnominate",))      @has_any_role(*MODERATION_ROLES) -    async def unwatch_command(self, ctx: Context, user: FetchedMember, *, reason: str) -> None: +    async def unwatch_command(self, ctx: Context, user: MemberOrUser, *, reason: str) -> None:          """          Ends the active nomination of the specified user with the given reason. @@ -323,7 +323,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):      @nomination_edit_group.command(name='reason')      @has_any_role(*MODERATION_ROLES) -    async def edit_reason_command(self, ctx: Context, nomination_id: int, actor: FetchedMember, *, reason: str) -> None: +    async def edit_reason_command(self, ctx: Context, nomination_id: int, actor: MemberOrUser, *, reason: str) -> None:          """Edits the reason of a specific nominator in a specific active nomination."""          if len(reason) > REASON_MAX_CHARS:              await ctx.send(f":x: Maxiumum allowed characters for the reason is {REASON_MAX_CHARS}.") @@ -417,7 +417,7 @@ class TalentPool(WatchChannel, Cog, name="Talentpool"):          await ctx.message.add_reaction(Emojis.check_mark)      @Cog.listener() -    async def on_member_ban(self, guild: Guild, user: Union[User, Member]) -> None: +    async def on_member_ban(self, guild: Guild, user: Union[MemberOrUser]) -> None:          """Remove `user` from the talent pool after they are banned."""          await self.unwatch(user.id, "User was banned.") diff --git a/bot/exts/utils/reminders.py b/bot/exts/utils/reminders.py index 441b0353f..144f7b537 100644 --- a/bot/exts/utils/reminders.py +++ b/bot/exts/utils/reminders.py @@ -12,13 +12,13 @@ from discord.ext.commands import Cog, Context, Greedy, group  from bot.bot import Bot  from bot.constants import Guild, Icons, MODERATION_ROLES, POSITIVE_REPLIES, Roles, STAFF_ROLES -from bot.converters import Duration +from bot.converters import Duration, UserMentionOrID  from bot.pagination import LinePaginator  from bot.utils.checks import has_any_role_check, has_no_roles_check  from bot.utils.lock import lock_arg  from bot.utils.messages import send_denial  from bot.utils.scheduling import Scheduler -from bot.utils.time import TimestampFormats, discord_timestamp, time_since +from bot.utils.time import TimestampFormats, discord_timestamp  log = logging.getLogger(__name__) @@ -27,6 +27,7 @@ WHITELISTED_CHANNELS = Guild.reminder_whitelist  MAXIMUM_REMINDERS = 5  Mentionable = t.Union[discord.Member, discord.Role] +ReminderMention = t.Union[UserMentionOrID, discord.Role]  class Reminders(Cog): @@ -172,46 +173,53 @@ class Reminders(Cog):          if not is_valid:              # No need to cancel the task too; it'll simply be done once this coroutine returns.              return -          embed = discord.Embed() -        embed.colour = discord.Colour.blurple() -        embed.set_author( -            icon_url=Icons.remind_blurple, -            name="It has arrived!" -        ) - -        # Let's not use a codeblock to keep emojis and mentions working. Embeds are safe anyway. -        embed.description = f"Here's your reminder: {reminder['content']}" - -        if reminder.get("jump_url"):  # keep backward compatibility -            embed.description += f"\n[Jump back to when you created the reminder]({reminder['jump_url']})" -          if expected_time:              embed.colour = discord.Colour.red()              embed.set_author(                  icon_url=Icons.remind_red, -                name=f"Sorry it should have arrived {time_since(expected_time)} !" +                name="Sorry, your reminder should have arrived earlier!"              ) +        else: +            embed.colour = discord.Colour.blurple() +            embed.set_author( +                icon_url=Icons.remind_blurple, +                name="It has arrived!" +            ) + +        # Let's not use a codeblock to keep emojis and mentions working. Embeds are safe anyway. +        embed.description = f"Here's your reminder: {reminder['content']}" +        # Here the jump URL is in the format of base_url/guild_id/channel_id/message_id          additional_mentions = ' '.join(              mentionable.mention for mentionable in self.get_mentionables(reminder["mentions"])          ) -        await channel.send(content=f"{user.mention} {additional_mentions}", embed=embed) +        jump_url = reminder.get("jump_url") +        embed.description += f"\n[Jump back to when you created the reminder]({jump_url})" +        partial_message = channel.get_partial_message(int(jump_url.split("/")[-1])) +        try: +            await partial_message.reply(content=f"{additional_mentions}", embed=embed) +        except discord.HTTPException as e: +            log.info( +                f"There was an error when trying to reply to a reminder invocation message, {e}, " +                "fall back to using jump_url" +            ) +            await channel.send(content=f"{user.mention} {additional_mentions}", embed=embed)          log.debug(f"Deleting reminder #{reminder['id']} (the user has been reminded).")          await self.bot.api_client.delete(f"bot/reminders/{reminder['id']}")      @group(name="remind", aliases=("reminder", "reminders", "remindme"), invoke_without_command=True)      async def remind_group( -        self, ctx: Context, mentions: Greedy[Mentionable], expiration: Duration, *, content: str +        self, ctx: Context, mentions: Greedy[ReminderMention], expiration: Duration, *, content: str      ) -> None:          """Commands for managing your reminders."""          await self.new_reminder(ctx, mentions=mentions, expiration=expiration, content=content)      @remind_group.command(name="new", aliases=("add", "create"))      async def new_reminder( -        self, ctx: Context, mentions: Greedy[Mentionable], expiration: Duration, *, content: str +        self, ctx: Context, mentions: Greedy[ReminderMention], expiration: Duration, *, content: str      ) -> None:          """          Set yourself a simple reminder. @@ -263,7 +271,7 @@ class Reminders(Cog):              }          ) -        mention_string = f"Your reminder will arrive {discord_timestamp(expiration, TimestampFormats.RELATIVE)}" +        mention_string = f"Your reminder will arrive on {discord_timestamp(expiration, TimestampFormats.DAY_TIME)}"          if mentions:              mention_string += f" and will mention {len(mentions)} other(s)" @@ -356,7 +364,7 @@ class Reminders(Cog):          await self.edit_reminder(ctx, id_, {"content": content})      @edit_reminder_group.command(name="mentions", aliases=("pings",)) -    async def edit_reminder_mentions(self, ctx: Context, id_: int, mentions: Greedy[Mentionable]) -> None: +    async def edit_reminder_mentions(self, ctx: Context, id_: int, mentions: Greedy[ReminderMention]) -> None:          """Edit one of your reminder's mentions."""          # Remove duplicate mentions          mentions = set(mentions) diff --git a/config-default.yml b/config-default.yml index 2412a7016..eaf8e0ad7 100644 --- a/config-default.yml +++ b/config-default.yml @@ -434,14 +434,12 @@ anti_spam:              max: 3 -  metabase: -    username: !ENV "METABASE_USERNAME" -    password: !ENV "METABASE_PASSWORD" -    url: "http://metabase.default.svc.cluster.local/api" +    username: !ENV      "METABASE_USERNAME" +    password: !ENV      "METABASE_PASSWORD" +    base_url:           "http://metabase.default.svc.cluster.local"      # 14 days, see https://www.metabase.com/docs/latest/operations-guide/environment-variables.html#max_session_age -    max_session_age: 20160 - +    max_session_age:    20160  big_brother: diff --git a/tests/bot/exts/moderation/infraction/test_infractions.py b/tests/bot/exts/moderation/infraction/test_infractions.py index b9d527770..f844a9181 100644 --- a/tests/bot/exts/moderation/infraction/test_infractions.py +++ b/tests/bot/exts/moderation/infraction/test_infractions.py @@ -195,7 +195,7 @@ class VoiceBanTests(unittest.IsolatedAsyncioTestCase):      async def test_voice_unban_user_not_found(self):          """Should include info to return dict when user was not found from guild."""          self.guild.get_member.return_value = None -        result = await self.cog.pardon_voice_ban(self.user.id, self.guild, "foobar") +        result = await self.cog.pardon_voice_ban(self.user.id, self.guild)          self.assertEqual(result, {"Info": "User was not found in the guild."})      @patch("bot.exts.moderation.infraction.infractions._utils.notify_pardon") @@ -206,7 +206,7 @@ class VoiceBanTests(unittest.IsolatedAsyncioTestCase):          notify_pardon_mock.return_value = True          format_user_mock.return_value = "my-user" -        result = await self.cog.pardon_voice_ban(self.user.id, self.guild, "foobar") +        result = await self.cog.pardon_voice_ban(self.user.id, self.guild)          self.assertEqual(result, {              "Member": "my-user",              "DM": "Sent" @@ -221,7 +221,7 @@ class VoiceBanTests(unittest.IsolatedAsyncioTestCase):          notify_pardon_mock.return_value = False          format_user_mock.return_value = "my-user" -        result = await self.cog.pardon_voice_ban(self.user.id, self.guild, "foobar") +        result = await self.cog.pardon_voice_ban(self.user.id, self.guild)          self.assertEqual(result, {              "Member": "my-user",              "DM": "**Failed**" diff --git a/tests/bot/exts/moderation/infraction/test_utils.py b/tests/bot/exts/moderation/infraction/test_utils.py index 5f95ced9f..eb256f1fd 100644 --- a/tests/bot/exts/moderation/infraction/test_utils.py +++ b/tests/bot/exts/moderation/infraction/test_utils.py @@ -94,8 +94,8 @@ class ModerationUtilsTests(unittest.IsolatedAsyncioTestCase):          test_case = namedtuple("test_case", ["get_return_value", "expected_output", "infraction_nr", "send_msg"])          test_cases = [              test_case([], None, None, True), -            test_case([{"id": 123987}], {"id": 123987}, "123987", False), -            test_case([{"id": 123987}], {"id": 123987}, "123987", True) +            test_case([{"id": 123987, "type": "ban"}], {"id": 123987, "type": "ban"}, "123987", False), +            test_case([{"id": 123987, "type": "ban"}], {"id": 123987, "type": "ban"}, "123987", True)          ]          for case in test_cases: | 
